Mir

Code review comment for lp:~andreas-pokorny/mir/libinput-input-device-provider

Revision history for this message
Robert Carr (robertcarr) wrote :

It looks like this is still work in progress? I can't find anywhere the new InputDeviceFactory is used (and it seems mi::InputDevice is still only a forward declared type).

Are you looking for advance review before preceding further or trying to land this as an intermediate step? From your perspective what is the next step?

My guess would be something like:
1. Modify EventHub to use InputDevice factory
2. Expand InputDevice interface to pull event reading in to interface
3. Move event hub code in to android InputDeviceImpl,add libinput device impl.

Is this where you are heading? Lets sync up and then ill review the rest! Things are looking sound so far.

review: Needs Information

« Back to merge proposal