Mir

Code review comment for lp:~andreas-pokorny/mir/fix-1391975

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

> + 78 and + 79 assume that drm drivers will provide us with sanely sized and
> supported cursor buffer sizes... That assumption might be wrong. Should I set
> a something like maximum to request?

Yes that's a big concern actually. A driver could feasibly have no small limitations. If it gives you 4096x4096 for example, we'd end up allocating 64MB just for a cursor.

We do need to impose some limit on the dimensions in our code. And if that limit is 64x64 then you might not need the drmGetCap stuff either :)

review: Needs Fixing

« Back to merge proposal