Mir

Code review comment for lp:~andreas-pokorny/mir/fix-1391975

Revision history for this message
Robert Carr (robertcarr) wrote :

Looks like Alexandros concerned is addressed.

Not sure I understand Daniels concern. drmGetCap is used PRIOR to the gbm_bo existing and to choose the maximum width/height values which can be passed to gbm_bo_create. It's conceivable as per the API for example that you would see there is a 512x512 cursor buffer choose to allocate a 256x256 one and receive a 128x128 one in response. I cant imagine any situation where we dont want the maximum sized cursor buffer, but this does seem to be the only correct way to use the API.

>> but also be careful to query what we're actually given:
>> gbm_bo_get_width
>> gbm_bo_get_height

As this branch does.

« Back to merge proposal