Code review comment for lp:~andreas-pokorny/mir/fix-1261647

(8) Inversion is slow and shouldn't be done unconditionally. We should cache the inverse and recalculate it only on demand inside inverse_transformation()...

865 + inverse_matrix = glm::inverse(transformation_matrix);

(9) Shouldn't the parameters here be const references for efficiency?

799 +geom::Point to_point(glm::vec4 pos)
804 +glm::vec4 to_vec(geom::Point pos)
809 +glm::vec4 to_vec(geom::Size s)

(10) I'm still seeing bug 1261647 can occur and is not fully fixed:
  1. Start mir_demo_server_shell and rotate it sideways (Ctrl+Alt+Left/Right)
  2. Start mir_demo_client_fingerpaint. You'll see it doesn't fit the full screen properly by default.
  3. Rotate the screen back to normal (Ctrl+Alt+Up).
  4. Draw in fingerpaint. It works but not if the initial click is near the right hand side. Only if the click started near the left can the drawing extend to the right.
Is this still bug 1261647 or a new one? I think it's essentially still the same bug.