Mir

Code review comment for lp:~andreas-pokorny/mir/example-configure-input-devices

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Looks good.

Nits:

1. s/touch pad/touchpad
90 + "Disable touch pad while typing on keyboard configuration [true, false]",

2. s/scrolll/scroll
+ "Select scrolll mode for touchpads: [{two-finger, edge}]",

3. s/accleration/acceleration
mouse_cursor_accleration_bias_opt;
mouse_cursor_accleration_bias;

4.
174 +void me::InputDeviceConfig::device_added(std::shared_ptr<mi::Device> const& device)

A more compact implementation would be

if (contains(device->capabilities(), mi::DeviceCapability::pointer))
{
    mi::PointerConfiguration pointer_config( device->pointer_configuration().value() );
    pointer_config.cursor_acceleration_bias = touchpad_cursor_accleration_bias;
    pointer_config.vertical_scroll_scale = touchpad_scroll_speed_scale;
    pointer_config.horizontal_scroll_scale = touchpad_scroll_speed_scale;
    device->apply_pointer_configuration(pointer_config);

    if (contains(device->capabilities(), mi::DeviceCapability::touchpad)))
    {
        mi::TouchpadConfiguration touch_config( device->touchpad_configuration().value() );
        touch_config.disable_while_typing = disable_while_typing;
        touch_config.click_mode = click_mode;
        touch_config.scroll_mode = scroll_mode;
        device->apply_touchpad_configuration(touch_config);
    }
}

review: Approve

« Back to merge proposal