Looks good.
Nits:
1. s/touch pad/touchpad 90 + "Disable touch pad while typing on keyboard configuration [true, false]",
2. s/scrolll/scroll + "Select scrolll mode for touchpads: [{two-finger, edge}]",
3. s/accleration/acceleration mouse_cursor_accleration_bias_opt; mouse_cursor_accleration_bias;
4. 174 +void me::InputDeviceConfig::device_added(std::shared_ptr<mi::Device> const& device)
A more compact implementation would be
if (contains(device->capabilities(), mi::DeviceCapability::pointer)) { mi::PointerConfiguration pointer_config( device->pointer_configuration().value() ); pointer_config.cursor_acceleration_bias = touchpad_cursor_accleration_bias; pointer_config.vertical_scroll_scale = touchpad_scroll_speed_scale; pointer_config.horizontal_scroll_scale = touchpad_scroll_speed_scale; device->apply_pointer_configuration(pointer_config);
if (contains(device->capabilities(), mi::DeviceCapability::touchpad))) { mi::TouchpadConfiguration touch_config( device->touchpad_configuration().value() ); touch_config.disable_while_typing = disable_while_typing; touch_config.click_mode = click_mode; touch_config.scroll_mode = scroll_mode; device->apply_touchpad_configuration(touch_config); } }
« Back to merge proposal
Looks good.
Nits:
1. s/touch pad/touchpad
90 + "Disable touch pad while typing on keyboard configuration [true, false]",
2. s/scrolll/scroll
+ "Select scrolll mode for touchpads: [{two-finger, edge}]",
3. s/accleration/ acceleration accleration_ bias_opt; accleration_ bias;
mouse_cursor_
mouse_cursor_
4. Config: :device_ added(std: :shared_ ptr<mi: :Device> const& device)
174 +void me::InputDevice
A more compact implementation would be
if (contains( device- >capabilities( ), mi::DeviceCapab ility:: pointer) ) :PointerConfigu ration pointer_config( device- >pointer_ configuration( ).value( ) ); config. cursor_ acceleration_ bias = touchpad_ cursor_ accleration_ bias; config. vertical_ scroll_ scale = touchpad_ scroll_ speed_scale; config. horizontal_ scroll_ scale = touchpad_ scroll_ speed_scale; >apply_ pointer_ configuration( pointer_ config) ;
{
mi:
pointer_
pointer_
pointer_
device-
if (contains( device- >capabilities( ), mi::DeviceCapab ility:: touchpad) ))
mi::TouchpadCo nfiguration touch_config( device- >touchpad_ configuration( ).value( ) );
touch_ config. disable_ while_typing = disable_ while_typing;
touch_ config. click_mode = click_mode;
touch_ config. scroll_ mode = scroll_mode;
device- >apply_ touchpad_ configuration( touch_config) ;
{
}
}