Mir

Code review comment for lp:~andreas-pokorny/mir/cursor-position-on-rotated-output

Revision history for this message
Robert Carr (robertcarr) wrote :

LGTM.

The MesaCursor tests might look a little nicer if the constants in: 13 +
214 + EXPECT_CALL(*output_container.outputs[12], move_cursor(geom::Point{112,100}));
215 + EXPECT_CALL(*output_container.outputs[12], move_cursor(geom::Point{150,96}));
216 +
217 + cursor.move_to({766, 112});
218 + cursor.move_to({770, 150});

et al were written symbolically (i.e. in terms of output width and cursor movement vectors)

Whitespace at 239

review: Approve

« Back to merge proposal