+ xkb_keysym_t update_state(uint32_t scan_code, MirKeyboardAction direction, ComposeState* compose_state); in light of + update_state(to_xkb_scan_code(scan_code), mir_keyboard_action_down, nullptr);
I think mir::optional_value<ComposeState*> as the new parameter makes sense. (or having two functions with different parameters).
not too bothered by that though, lgtm
« Back to merge proposal
+ xkb_keysym_t update_ state(uint32_ t scan_code, MirKeyboardAction direction, ComposeState* compose_state); state(to_ xkb_scan_ code(scan_ code), mir_keyboard_ action_ down, nullptr);
in light of
+ update_
I think mir::optional_ value<ComposeSt ate*> as the new parameter makes sense. (or having two functions with different parameters).
not too bothered by that though, lgtm