Mir

Code review comment for lp:~andreas-pokorny/mir/combine-modifier-state-accross-devices

  1. combine-modifier-state-accross-devices
  2. Merge into development-branch
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

> Hm. Couldn't you just keep the MirInputEventModifiers in the key_event()
> constructor and then not call mev::set_modifier(,seat->event_modifier()) on
> key events? That should then work just like it does today?

Ah - so combine modifiers only for non key events, but keep per device modifers for key events..
So you cannot do for example ExternalKeyboard-Ctrl + BuiltinKeyboard-C to break stuff (which is what x11 currently does).

.... sounds good to me .. and simple to implement.

« Back to merge proposal