Code review comment for lp:~andreas-pokorny/mir/allow-transparent-server-buffers

286 + std::shared_ptr<graphics::DisplayConfigurationPolicy> base_policy;

Should be const.

~~~~

344 +#include <cstdint>
345 +#include "mir_toolkit/common.h"

http://unity.ubuntu.com/mir/cppguide/index.html?showone=Names_and_Order_of_Includes#Names_and_Order_of_Includes

~~~~

93 +
94 + using mir::examples::ServerConfiguration::the_options;

Not used

~~~~

82 + void launch_client()
83 + {
84 + if (the_options()->is_set(launch_child_opt))
85 + {
86 + char buffer[128] = {0};
87 + sprintf(buffer, "fd://%d", the_connector()->client_socket_fd());
88 + setenv("MIR_SOCKET", buffer, 1);
89 + auto ignore = system((the_options()->get(launch_child_opt, "") + "&").c_str());
90 + (void)ignore;
91 + }

This code looks familiar - maybe it should be in a common base class? (mir::examples::ServerConfiguration?)

I'm not sure how useful the "greeter" is as an example server. Certainly, if it exists, there ought to be more documentation on how to get it to do anything interesting.