Code review comment for lp:~andreas-pokorny/mir/allow-transparent-server-buffers

I think my curly braces placement is wrong too? In:

88 + for (auto const& f : availableFormats )
89 + {
90 + if (f == mir_pixel_format_abgr_8888 ||
91 + f == mir_pixel_format_argb_8888)
92 + {

Yes didnt like that passing around either, but I thought a pixel format configuration would also be reasonable to some degree for non nested platforms. We could turn that into a list of DisplayConfigurationPolicies (for convenience) and extend the DisplayConfiguration interface to be able to also affect the preferred PixelFormat on the Output?

I added those header files there since IDEs that support cmake see those header files that are part of the project, and shows them, and cmake can separate between things to compile and other stuff.