Mir

Code review comment for lp:~andreas-pokorny/mir/add-dispatchable-alarm-factory

Revision history for this message
Chris Halse Rogers (raof) wrote :

I don't think you need a separate Alarm::Internal, because you can just register the relevant mir::Fd + std::function<> pair with the MultiplexingDispatchable.

I'm OK with it as it is, but still have the gut feeling that it could be significantly simpler.

review: Approve

« Back to merge proposal