Mir

Code review comment for lp:~andreas-pokorny/mir/add-dispatchable-alarm-factory

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> oops I meant:
> class AlarmFactory : public time::AlarmFactory, public dispatch::Dispatchable
> {
> ...
> ReadableFd const timer_fd;
> };

Hmm. If that's the intention I prefer:

class AlarmFactory : public time::AlarmFactory, public dispatch::Dispatchable,
    private ReadableFd
{
   ...
};

But for that dispatch::Dispatchable needs to be a virtual base class of ReadableFd.

review: Abstain

« Back to merge proposal