Merge lp:~andrea.corbellini/ubuntu/raring/nvidia-common/detector-getData-fixes into lp:ubuntu/raring/nvidia-common

Proposed by Andrea Corbellini
Status: Needs review
Proposed branch: lp:~andrea.corbellini/ubuntu/raring/nvidia-common/detector-getData-fixes
Merge into: lp:ubuntu/raring/nvidia-common
Diff against target: 31 lines (+7/-3)
1 file modified
NvidiaDetector/nvidiadetector.py (+7/-3)
To merge this branch: bzr merge lp:~andrea.corbellini/ubuntu/raring/nvidia-common/detector-getData-fixes
Reviewer Review Type Date Requested Status
Alberto Milone Pending
Review via email: mp+130694@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

64. By Andrea Corbellini

Do not fail with an exception if an nvidia package name cannot be parsed.

63. By Andrea Corbellini

Do not detect experimental nvidia packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NvidiaDetector/nvidiadetector.py'
--- NvidiaDetector/nvidiadetector.py 2011-08-12 17:33:04 +0000
+++ NvidiaDetector/nvidiadetector.py 2012-10-21 09:15:25 +0000
@@ -133,7 +133,8 @@
133133
134 for package in apt.Cache():134 for package in apt.Cache():
135 if (not package.name.startswith('nvidia-')135 if (not package.name.startswith('nvidia-')
136 or 'updates' in package.name):136 or 'updates' in package.name
137 or 'experimental' in package.name):
137 continue138 continue
138 try:139 try:
139 m = package.candidate.record['Modaliases']140 m = package.candidate.record['Modaliases']
@@ -146,7 +147,11 @@
146 # package names can be like "nvidia-173:i386" and we need to147 # package names can be like "nvidia-173:i386" and we need to
147 # extract the driver flavour from the name e.g. "173"148 # extract the driver flavour from the name e.g. "173"
148 stripped_package_name = package.name.split('-', 1)[1].split(':', 1)[0]149 stripped_package_name = package.name.split('-', 1)[1].split(':', 1)[0]
149 driver_version = self.__get_value_from_name(stripped_package_name)150 try:
151 driver_version = self.__get_value_from_name(stripped_package_name)
152 except ValueError:
153 logging.error('Package name %s cannot be parsed' % package.name)
154 continue
150155
151 try:156 try:
152 for part in m.split(')'):157 for part in m.split(')'):
@@ -439,4 +444,3 @@
439444
440#if __name__ == '__main__':445#if __name__ == '__main__':
441# main()446# main()
442

Subscribers

People subscribed via source and target branches