Merge lp:~andrea.corbellini/ubiquity/bug-531343 into lp:ubiquity

Proposed by Andrea Corbellini
Status: Merged
Merge reported by: Stéphane Graber
Merged at revision: not available
Proposed branch: lp:~andrea.corbellini/ubiquity/bug-531343
Merge into: lp:ubiquity
Diff against target: 36 lines (+8/-3)
1 file modified
ubiquity/frontend/kde_ui.py (+8/-3)
To merge this branch: bzr merge lp:~andrea.corbellini/ubiquity/bug-531343
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+20558@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stéphane Graber (stgraber) wrote :

Was already fixed in commit below:

stgraber@castiana:~/data/code/ubiquity/ubiquity$ bzr log -r 3896.1.1
------------------------------------------------------------
revno: 3896.1.1
committer: Roman Shtylman <email address hidden>
branch nick: dev
timestamp: Sat 2010-03-06 16:35:37 -0500
message:
  fix for LP: #532533

  kubuntu install able to progress past language screen

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubiquity/frontend/kde_ui.py'
2--- ubiquity/frontend/kde_ui.py 2010-02-26 14:43:54 +0000
3+++ ubiquity/frontend/kde_ui.py 2010-03-03 14:58:16 +0000
4@@ -113,10 +113,10 @@
5 event.ignore()
6
7 class Controller(ubiquity.frontend.base.Controller):
8- def translate(self, lang=None, just_me=True, reget=False):
9+ def translate(self, lang=None, just_me=True, not_me=False, reget=False):
10 if lang:
11 self._wizard.locale = lang
12- self._wizard.translate_pages(lang, just_me, reget)
13+ self._wizard.translate_pages(lang, just_me, not_me, reget)
14
15 def allow_go_forward(self, allowed):
16 self._wizard.allow_go_forward(allowed)
17@@ -460,13 +460,18 @@
18 rv = reduce(recurse, parentWidget.children(), [parentWidget])
19 return rv
20
21- def translate_pages(self, lang=None, just_current=True, reget=False):
22+ def translate_pages(
23+ self, lang=None, just_current=True, not_current=False, reget=False):
24+ current_page = self.pages[self.pagesindex]
25 if just_current:
26 pages = [self.pages[self.pagesindex]]
27 else:
28 pages = self.pages
29 widgets = []
30 for p in pages:
31+ # There's no sense retranslating the page we're leaving.
32+ if not_current and p == current_page:
33+ continue
34 prefix = p.ui.get('plugin_prefix')
35 for w in p.widgets:
36 for c in self.all_children(w):

Subscribers

People subscribed via source and target branches

to status/vote changes: