Code review comment for lp:~andrea.corbellini/tarmac/save-commit-author

Revision history for this message
Paul Hummer (rockstar) wrote :

Andrea-

  I really appreciate your effort in this, and for participating in Tarmac development. There are a number of flaws in this implementation. For instance, what if the user has elected to hide his email address from everyone. What if the user is committing code under a different user name (I do this a lot, since I have Canonical projects and non-Canonical projects).

  I'm quite happy to sit down with you and talk about an implementation that would work, and happy to help you along with it. I really appreciate your help in making Tarmac better.

review: Disapprove

« Back to merge proposal