Code review comment for lp:~andrea.corbellini/launchpad/fix-406523

Revision history for this message
Paul Hummer (rockstar) wrote :

> > I don't know exactly what's going on here, but the test that fails does have
> a
> > connection to this code, so I doubt it's a spurious failure. Try to get it
> to
> > work and let me know if you have problems.
>
> Argh! For some reasons I haven't seen xx-display-filesize-attachment.txt in
> the output of grep. Now it's fixed, and works as expected.
>
> Sorry for this! I hope this won't happen again.

It's not a big deal. This happens in more cases than you'd think, and it's the entire reason we land things through ec2test.

In the future, when you make incremental changes, it's good to post the incremental diff. That way, I don't have to grab your branch to see the changes you've made. I've learned that in Launchpad development, the best thing you can do is make your reviewer's job easy. :)

review: Approve

« Back to merge proposal