Code review comment for lp:~andrea.corbellini/launchpad/fix-406523

Revision history for this message
Tom Haddon (mthaddon) wrote :

> Thanks for doing this branch. It looks like a good first step.
>
> I'm very suspicious of the unconditional return statement in line 51. It looks
> like you added that during development and that it should be removed.
>
> Other than that, this branch looks good. Approved*. I'm a trainee reviewer so
> you'll need to get rockstar to approve my change, and then have an admin look
> at it because it changes configuration.

I've checked the production-configs branch and we don't set this value, so I think it's safe to change it.

Thanks for checking with us, that's definitely needed for any config change.

review: Approve

« Back to merge proposal