Code review comment for lp:~andrea.corbellini/launchpad/fix-406523

Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

> Hi Andreas-
>
> Thanks for this work! I agree with Leonard concerning the changes to
> lib/canonical/database/revision.py - I think it would be best to just revert
> both changes in there. Yes, you're removing a line, but we generally don't
> make whitespace changes to a file unless we actually edit it so that we don't
> cause spurious conflicts. Other than that, thanks for looking into this!

I've re-added the blankline at the end of the file too. Now everything should be fine, thanks!

« Back to merge proposal