Code review comment for lp:~andrea.corbellini/launchpad/fix-406523

Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

> Thanks for doing this branch. It looks like a good first step.
>
> I'm very suspicious of the unconditional return statement in line 51. It looks
> like you added that during development and that it should be removed.

I've removed the `return` in the last revision: http://bazaar.launchpad.net/~andrea-bs/launchpad/fix-406523/revision/9007.
The reason why you see it in the diff is because is hasn't been updated after my last push (there's a bug about this somewhere).

> Other than that, this branch looks good. Approved*. I'm a trainee reviewer so
> you'll need to get rockstar to approve my change, and then have an admin look
> at it because it changes configuration.

Thanks for your help!

« Back to merge proposal