Code review comment for lp:~andrea.corbellini/launchpad/fix-406523

Revision history for this message
Paul Hummer (rockstar) wrote :

Hi Andreas-

  Thanks for this work! I agree with Leonard concerning the changes to lib/canonical/database/revision.py - I think it would be best to just revert both changes in there. Yes, you're removing a line, but we generally don't make whitespace changes to a file unless we actually edit it so that we don't cause spurious conflicts. Other than that, thanks for looking into this!

review: Approve

« Back to merge proposal