Code review comment for lp:~andrea.corbellini/launchpad/bug-630302

Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

Hi. I though this was an easy fix, so I didn't have a pre-imp chat with anybody. Thank you for having pointed me to bug #655565: it shows many important use cases for this feature.

About the issues regarding Person.id, I can't find them. I have no problems to add a new database column "public_id" if needed, but I'd like to know the nature of such issues, just to be sure to avoid them.

Solved the Person.id problem, here's what I'm willing to do with this branch, if you agree:

* Expand my work to the API: adding the redirect, creating a new method "people.getById()" (or similar), adding a new attribute "person.id".
* Remove the "Permalink" <dl> from people pages.

« Back to merge proposal