Code review comment for lp:~andrea.corbellini/launchpad/blueprint-whiteboard-diffs

On 24.07.2009 11:27, Björn Tillenius wrote:

>> I wonder if you should first line-wrap the old text and the new text,
>> and then call get_uniified_diff() for these line-wrapped versions..
>
> The text_width argument to get_uniified_diff() is used to wrap long
> lines first, to produce reasonably looking diffs. Well, at least it
> should get used, looking at the implementation that argument is actually
> ignored and 72 is hard-coded. Anyway, no need to wrap the text before
> calling get_uniified_diff()>

whoops, sure. Should have lookad at get_unified_diff() first...

Abel