Code review comment for lp:~andrea.corbellini/a4/test-suite
Revision history for this message
| Andrea Corbellini (andrea.corbellini) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4d1350f
(Get the code!)
> I couldn't make the tests work...
I suppose that's because you have set Italian as your language. Using English should work, could you confirm, please?
> the roi.svg test image is something I use to develop A4...
Then I will re-add it to the branch. I deleted it because I found it very similar to the other image, sorry.
> Also, you made several changes to the properties of the objects in A4_nested_
I've just run the 'Delete unused defs' function of Inkscape, so it should be fine.
> Anyway, the handling of test files is a complex matter...
I will put them in tests/images. However I would like to give them more descriptive names, but this can be done in the future.
> One more (possibly unrelated) thing: LDTP is a GUI automation framework...
I generally prefer to write short merge proposals focused on a single feature to make them easier to review. That's why you see just the behaviour-driven tests, but writing tests for the code itself is on my roadmap too (in fact, many things are difficult to test with LDTP).