Code review comment for lp:~andrea.corbellini/a4/clean-player

On Wed, 2010-07-14 at 09:15 +0000, Andrea Gasparini wrote:
> Review: Needs Fixing
> Completely agree on the cleaning part.
>
> Just a little fix, these lines:
> 175 + self.area = drawing_area
> 176 + self.drawing_area.queue_draw()
> have to be:
> 175 + self.area = drawing_area
> 176 + self.area.queue_draw()
> Otherwise it wont work.

Oops, sorry! I thought I had tested everything.

> About *Player class, perhaps it'd be fine to merge CairoPlayer and
> GtkCairoPlayer (let's still think about it a little); although the
> base Player class could be useful, as it could be tested without a
> GUI, and cause it could be subclassed by a future Wx/Qt/web/whatever
> based GUI.

That's fine, I agree.

--
Ubuntu member | http://www.ubuntu.com/
BeeSeek member | http://www.beeseek.org/