Merge ~andersson123/autopkgtest-cloud:upgrade-charm-to-docs into autopkgtest-cloud:master

Proposed by Tim Andersson
Status: Needs review
Proposed branch: ~andersson123/autopkgtest-cloud:upgrade-charm-to-docs
Merge into: autopkgtest-cloud:master
Diff against target: 23 lines (+8/-4)
1 file modified
docs/deploying.rst (+8/-4)
Reviewer Review Type Date Requested Status
Skia Needs Fixing
Review via email: mp+463293@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Skia (hyask) wrote :

I'm not sure I'm the best person to approve this. Moreover, I have uncertainties around the upgrade of charms, like what would happen to the rabbitmq charm that we fixed on a particular version in the service-bundle?

Revision history for this message
Tim Andersson (andersson123) wrote :

It stays pinned to the version in the juju config I believe, I've been using this script for a long time with no issues as an alternative to mojo run when all that's needed is a code update

Revision history for this message
Tim Andersson (andersson123) wrote :

ping on this. The upgrade-charm script adheres to version pinning and channel pinning as in the service-bundle. Please re-review

Revision history for this message
Skia (hyask) :
review: Needs Fixing
Revision history for this message
Tim Andersson (andersson123) :
Revision history for this message
Tim Andersson (andersson123) wrote :

amended and ready for re-review

Unmerged commits

98af218... by Tim Andersson

docs: remove mention of new dependencies requiring a unit replacement

Succeeded
[SUCCEEDED] pre_commit:0 (build)
[SUCCEEDED] unit_tests:0 (build)
[SUCCEEDED] build_charms:0 (build)
13 of 3 results
aa1780a... by Tim Andersson

docs: mention upgrade_charm script in Deploying section

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/docs/deploying.rst b/docs/deploying.rst
2index 13fd5bb..8a6dd64 100644
3--- a/docs/deploying.rst
4+++ b/docs/deploying.rst
5@@ -190,10 +190,14 @@ Where $charm is either equal to "web" or "cloud-worker".
6 Then run ``mojo run`` on the system where you want to deploy the update - this
7 will pull the updated charm from the charm store.
8
9-Please note, if you have made changes to the charm that add new package dependencies,
10-a mojo run will not update this on the relevant units. For this to take place, you must
11-either ``remove-unit`` and ``add-unit`` the relevant unit, or install the new dependencies
12-manually on the unit.
13+If, however, you're doing a charm update that only involves code changes,
14+without any required changes to ``juju config`` options, you can run
15+the following script:
16+
17+``autopkgtest-cloud/mojo/upgrade-charm``
18+
19+Which will update the code for all the charms with the latest revision in
20+charmhub, without running all the various ``mojo run`` stages.
21
22 Tagging the charm revisions
23 ---------------

Subscribers

People subscribed via source and target branches