Merge ~andersson123/autopkgtest-cloud:dont-check-huge-tests-for-duplicate-queued-items into autopkgtest-cloud:master

Proposed by Tim Andersson
Status: Merged
Merged at revision: 8f6d9cb3533da5f85308745b66c946a10eeee9c3
Proposed branch: ~andersson123/autopkgtest-cloud:dont-check-huge-tests-for-duplicate-queued-items
Merge into: autopkgtest-cloud:master
Diff against target: 14 lines (+3/-0)
1 file modified
charms/focal/autopkgtest-web/webcontrol/request/submit.py (+3/-0)
Reviewer Review Type Date Requested Status
Brian Murray Needs Fixing
Review via email: mp+460711@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Please add a comment so we remember the use case and reasoning for not checking if the request is in the huge queue.

review: Approve
Revision history for this message
Brian Murray (brian-murray) :
review: Needs Fixing
Revision history for this message
Tim Andersson (andersson123) wrote :

I added a comment, please re-review, not sure if the comment is verbose enough though?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
2index 72d493b..4dc1eef 100644
3--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
4+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
5@@ -642,6 +642,9 @@ class Submit:
6 "triggers": sorted(req_triggers),
7 }
8 for test_type in data:
9+ # As requested by some ubuntu devs, we don't check the huge queue for duplicates.
10+ if test_type == "huge":
11+ continue
12 for release in data[test_type]:
13 for arch in data[test_type][release]:
14 packages = data[test_type][release][arch]

Subscribers

People subscribed via source and target branches