Merge ~andersson123/autopkgtest-cloud:autopkgtest-worker-restart into autopkgtest-cloud:master

Proposed by Tim Andersson
Status: Merged
Merged at revision: 2f119ea093ff0595360b9468a1c2c595664da23f
Proposed branch: ~andersson123/autopkgtest-cloud:autopkgtest-worker-restart
Merge into: autopkgtest-cloud:master
Diff against target: 13 lines (+1/-1)
1 file modified
charms/focal/autopkgtest-cloud-worker/units/autopkgtest@.service (+1/-1)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Review via email:
To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

Removing those only makes systemd use the defaults (DefaultStartLimitInterval, DefaultStartLimitBurst, see systemd-system.conf(5)).

Also the commit message says "restart workers when they're done", but the worker process should never be "done" (it's long lived), right? So that's unclear.

review: Disapprove
Revision history for this message
Tim Andersson (andersson123) wrote :

Amended, please re-review

Revision history for this message
Paride Legovini (paride) wrote :


review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-cloud-worker/units/autopkgtest@.service b/charms/focal/autopkgtest-cloud-worker/units/autopkgtest@.service
2index da89f08..a94f14d 100644
3--- a/charms/focal/autopkgtest-cloud-worker/units/autopkgtest@.service
4+++ b/charms/focal/autopkgtest-cloud-worker/units/autopkgtest@.service
5@@ -31,7 +31,7 @@ ExecReload=/bin/kill -HUP $MAINPID
6 SuccessExitStatus=0 99 SIGTERM SIGHUP
7 RestartSec=5min
8 Restart=on-failure
11 StartLimitBurst=3
13 [Install]


People subscribed via source and target branches