Merge ~andersson123/autopkgtest-cloud:add_status_to_webpage into autopkgtest-cloud:master

Proposed by Tim Andersson
Status: Merged
Merged at revision: 63822524d30383aee8bc56e2443f1f01fbb40275
Proposed branch: ~andersson123/autopkgtest-cloud:add_status_to_webpage
Merge into: autopkgtest-cloud:master
Diff against target: 12 lines (+1/-0)
1 file modified
charms/focal/autopkgtest-web/webcontrol/templates/browse-layout.html (+1/-0)
Reviewer Review Type Date Requested Status
Brian Murray Approve
Paride Legovini Approve
Review via email: mp+451044@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

I find the "autopkgtest" is word is a bit redundant, maybe just

  Infrastructure status updates

is enough. Anyway this is technically OK. I'm approving but I'd also like to hear if Brian likes it, given that it's a UI change related to the visibility of the team.

review: Approve
Revision history for this message
Brian Murray (brian-murray) wrote :

This has been put into the "Machine readable data" section and it isn't that. I'd rather see this in the top "nav bar" as this will also make it available from most if not all pages.

review: Needs Fixing
Revision history for this message
Tim Andersson (andersson123) wrote :

Tested in staging! Ready to go IMO

Revision history for this message
Brian Murray (brian-murray) wrote :

Looks create, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-web/webcontrol/templates/browse-layout.html b/charms/focal/autopkgtest-web/webcontrol/templates/browse-layout.html
2index b47203f..d626e3d 100644
3--- a/charms/focal/autopkgtest-web/webcontrol/templates/browse-layout.html
4+++ b/charms/focal/autopkgtest-web/webcontrol/templates/browse-layout.html
5@@ -31,6 +31,7 @@
6 <li><a href="{{base_url}}running">Running</a></li>
7 <li><a href="{{base_url}}statistics">Statistics</a></li>
8 <li><a href="https://wiki.ubuntu.com/ProposedMigration#autopkgtests">Documentation</a></li>
9+ <li><a href="https://discourse.ubuntu.com/t/autopkgtest-service/34490">Status</a></li>
10 <li><a href="https://autopkgtest-cloud.readthedocs.io/">Docs for admins</a></li>
11 </ul>
12 </div><!--/.nav-collapse -->

Subscribers

People subscribed via source and target branches