Merge ~andersson123/autopkgtest-cloud:custom_server_error_message into autopkgtest-cloud:master

[Tim Andersson]

[Tim Andersson (andersson123)]

irc.libera.chat

[Paride Legovini (paride)]

Inline questions.

review: Needs Information

[Tim Andersson (andersson123)]

I've made amendments based on your comments and I'm going to test it in staging now.

[Tim Andersson (andersson123)]

Hm. It's not working now for some reason.

[Tim Andersson (andersson123)]

I'm going to repack the charm from the previous commit and test it again.

[Tim Andersson (andersson123)]

Really weird. I reverted to prior commit, it worked, and i hotfixed the code back in and it worked. Strange. I'll clean up the MP and consider it ready for review

[Tim Andersson (andersson123)]

Let's hold on this, it seems that this change means that the traceback no longer goes to error.log, I'll make an amendment.

[Tim Andersson (andersson123)]

Amended and rebased.

[Paride Legovini (paride)]

One nit, otherwise LGTM/

review: Needs Fixing

[Tim Andersson (andersson123)]

:facepalm:

[Paride Legovini (paride)]

review: Approve

diff --git a/charms/focal/autopkgtest-web/webcontrol/request/app.py b/charms/focal/autopkgtest-web/webcontrol/request/app.py
index 5f47be2..55631f0 100644
--- a/charms/focal/autopkgtest-web/webcontrol/request/app.py
+++ b/charms/focal/autopkgtest-web/webcontrol/request/app.py
@@ -299,3 +299,23 @@ def logout():
     """Clear user session, logging them out."""
     session.clear()
     return redirect(oid.get_next_url())
+
+
[e-mail](Exception)
+def all_exception_handler(error):
+    # If the exception doesn't have the exit_code method, it's not an expected
+    # exception defined in helpers/exceptions.py
+    try:
+        return invalid(error, error.exit_code())
+    except Exception:
+        return (
+            HTML.format(
+                (
+                    "<p>A server error has occured, please contact a member of the Ubuntu QA team. "
+                    + "You can contact them via the ubuntu-quality mailing list, "
+                    + "or via the #ubuntu-quality IRC channel on irc.libera.chat. Traceback: %s</p>"
+                    % str(error)
+                ),
+            ),
+            500,
+        )