I don't think running unit tests belongs to pre-commit.
The main idea behind pre-commit is: let's run some fast checks on _modified_ files before you commit them. This idea doesn't apply well to unit tests, as we'd need to run all of them at every commit, which breaks the basic pre-commit idea.
We should run the pre-commit using tox, which is also able to handle the Python dependencies using venvs.
(Tox is also a better place where to run pylint.)
Dropped by accident?
I stopped reviewing here. Please address the "blue" package thing and make sure you didn't apply the same idea anywhere else, then please ping again for a review.
I don't think running unit tests belongs to pre-commit.
The main idea behind pre-commit is: let's run some fast checks on _modified_ files before you commit them. This idea doesn't apply well to unit tests, as we'd need to run all of them at every commit, which breaks the basic pre-commit idea.
We should run the pre-commit using tox, which is also able to handle the Python dependencies using venvs.
(Tox is also a better place where to run pylint.)
Dropped by accident?
I stopped reviewing here. Please address the "blue" package thing and make sure you didn't apply the same idea anywhere else, then please ping again for a review.
Preserving your comments paride.