Merge ~andersson123/autopkgtest-cloud:seed_new_release_neutral_results into autopkgtest-cloud:master

[Tim Andersson]

[Tim Andersson (andersson123)]

Maybe, actually, it's better to keep the exit codes and add 8 to them, which is the neutral exit code right? Do we want to filter on exit codes at all? What do you think?

[Brian Murray (brian-murray)]

The point of seed-new-release is to copy successful test results for the new release and by removing the exit code checking we'd then end up copying failures forward to the new release. So yes it is better to keep the exit codes and yes 8 is a neutral result.

Additionally, the change you suggested would make the two database queries identical. Which incidentally makes me wonder if the queries can be written in such a way that they don't return duplicate results and if that would speed up the seed-new-release process.

review: Needs Fixing

[Tim Andersson (andersson123)]

I've amended the exitcode, I'm not sure we can speed up the script much. The swift connection checks for duplicates anyway and doesn't copy if one exists I believe, so an external check I don't think would add much. But there could be a way to change the SQL query which I think is what you were suggesting, but I'm not well versed enough in SQL to say.

[Brian Murray (brian-murray)]

review: Approve

[Brian Murray (brian-murray)]

I also updated the comments in the code to explain that neutral results are also copied.

[Tim Andersson (andersson123)]

Ah, mb, I missed that

diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release
index 64819ae..77176c7 100755
--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release
+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release
@@ -163,8 +163,8 @@ for package, arch, run_id in db_con.execute(
     "SELECT package, arch, MAX(run_id) "
     "FROM test, result "
     "WHERE test.id = result.test_id AND release = '%s' "
-    "   AND (exitcode = 0 OR exitcode = 2 "
-    "        OR triggers = 'migration-reference/0') "
+    "   AND (exitcode = 0 OR exitcode = 2 OR exitcode = 8 "
+    "   OR triggers = 'migration-reference/0') "
     "GROUP BY package, arch" % args.old_release
 ):
     copy_run_results(