Code review comment for ~andch/ubuntu/+source/systemd:ubuntu-focal-lp1967038

Revision history for this message
Lukas Märdian (slyon) wrote :

It would be nice to have some DEP-3 patch headers with this distro patch (https://dep-team.pages.debian.net/deps/dep3/), and also prefix the patch filename with the bug number (e.g. "debian/patches/lp1967038-hwdb-Add-mic-mute-key-mapping-for-HP-Elite-x360.patch").

Especially something like: "Origin: upstream https://github.com/systemd/systemd/commit/f09f6dc2c8f59b2b58159cc413b605a547c8646e"

But this is a time critical patch and things are pretty obvious with this upstream cherry-pick, so we'll keep it as is.

review: Approve

« Back to merge proposal