Merge lp:~andatche/cloud-init/freebsd-improvements into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Ben Arblaster
Status: Merged
Merged at revision: 1193
Proposed branch: lp:~andatche/cloud-init/freebsd-improvements
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Prerequisite: lp:~andatche/cloud-init/freebsd-pkg-support
Diff against target: 70 lines (+21/-9) (has conflicts)
2 files modified
cloudinit/distros/freebsd.py (+16/-4)
config/cloud.cfg-freebsd (+5/-5)
Text conflict in cloudinit/distros/freebsd.py
To merge this branch: bzr merge lp:~andatche/cloud-init/freebsd-improvements
Reviewer Review Type Date Requested Status
Scott Moser Pending
Review via email: mp+278427@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cloudinit/distros/freebsd.py'
--- cloudinit/distros/freebsd.py 2015-11-24 10:46:14 +0000
+++ cloudinit/distros/freebsd.py 2015-11-24 10:46:15 +0000
@@ -244,9 +244,21 @@
244 util.logexc(LOG, "Failed to create user %s", name)244 util.logexc(LOG, "Failed to create user %s", name)
245 raise e245 raise e
246246
247 # TODO:
248 def set_passwd(self, user, passwd, hashed=False):247 def set_passwd(self, user, passwd, hashed=False):
249 return False248 cmd = ['pw', 'usermod', user]
249
250 if hashed:
251 cmd.append('-H')
252 else:
253 cmd.append('-h')
254
255 cmd.append('0')
256
257 try:
258 util.subp(cmd, passwd, logstring="chpasswd for %s" % user)
259 except Exception as e:
260 util.logexc(LOG, "Failed to set password for %s", user)
261 raise e
250262
251 def lock_passwd(self, name):263 def lock_passwd(self, name):
252 try:264 try:
@@ -400,10 +412,10 @@
400 cmd.extend(pkglist)412 cmd.extend(pkglist)
401413
402 # Allow the output of this to flow outwards (ie not be captured)414 # Allow the output of this to flow outwards (ie not be captured)
403 util.subp(cmd, env=e, capture=False) 415 util.subp(cmd, env=e, capture=False)
404416
405 def set_timezone(self, tz):417 def set_timezone(self, tz):
406 return418 distros.set_etc_timezone(tz=tz, tz_file=self._find_tz_file(tz))
407419
408 def update_package_sources(self):420 def update_package_sources(self):
409 self._runner.run("update-sources", self.package_command,421 self._runner.run("update-sources", self.package_command,
410422
=== modified file 'config/cloud.cfg-freebsd'
--- config/cloud.cfg-freebsd 2014-10-08 13:37:05 +0000
+++ config/cloud.cfg-freebsd 2015-11-24 10:46:15 +0000
@@ -49,10 +49,10 @@
49# - mounts49# - mounts
50 - ssh-import-id50 - ssh-import-id
51 - locale51 - locale
52# - set-passwords52 - set-passwords
53# - package-update-upgrade-install53 - package-update-upgrade-install
54# - landscape54# - landscape
55# - timezone55 - timezone
56# - puppet56# - puppet
57# - chef57# - chef
58# - salt-minion58# - salt-minion
@@ -80,9 +80,9 @@
80system_info:80system_info:
81 distro: freebsd81 distro: freebsd
82 default_user:82 default_user:
83 name: beastie83 name: freebsd
84 lock_passwd: True84 lock_passwd: True
85 gecos: FreeBSD85 gecos: FreeBSD
86 groups: [wheel]86 groups: [wheel]
87 sudo: ["ALL=(ALL) NOPASSWD:ALL"]87 sudo: ["ALL=(ALL) NOPASSWD:ALL"]
88 shell: /bin/sh88 shell: /bin/tcsh