Merge lp:~and471/update-manager/fix-bug-386196 into lp:update-manager

Proposed by Andrew
Status: Merged
Merged at revision: 1858
Proposed branch: lp:~and471/update-manager/fix-bug-386196
Merge into: lp:update-manager
Diff against target: 50 lines (+21/-1)
2 files modified
UpdateManager/UpdateManager.py (+6/-1)
data/update-manager.schemas.in (+15/-0)
To merge this branch: bzr merge lp:~and471/update-manager/fix-bug-386196
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+28563@code.launchpad.net

Description of the change

(see commit message and bug report https://bugs.launchpad.net/update-manager/+bug/386196)

To post a comment you must log in.
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This change is in line with the specification I'm working on for how updates should be presented.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'UpdateManager/UpdateManager.py'
--- UpdateManager/UpdateManager.py 2010-06-24 12:43:24 +0000
+++ UpdateManager/UpdateManager.py 2010-06-26 16:22:23 +0000
@@ -193,6 +193,8 @@
193 init_proxy(self.gconfclient)193 init_proxy(self.gconfclient)
194 # init show version194 # init show version
195 self.show_versions = self.gconfclient.get_bool("/apps/update-manager/show_versions")195 self.show_versions = self.gconfclient.get_bool("/apps/update-manager/show_versions")
196 # init summary_before_name
197 self.summary_before_name = self.gconfclient.get_bool("/apps/update-manager/summary_before_name")
196 # keep track when we run (for update-notifier)198 # keep track when we run (for update-notifier)
197 self.gconfclient.set_int("/apps/update-manager/launch_time", int(time.time()))199 self.gconfclient.set_int("/apps/update-manager/launch_time", int(time.time()))
198200
@@ -816,7 +818,10 @@
816 if not pkg.is_installed:818 if not pkg.is_installed:
817 name += _(" (New install)")819 name += _(" (New install)")
818 summary = xml.sax.saxutils.escape(pkg.summary)820 summary = xml.sax.saxutils.escape(pkg.summary)
819 contents = "<b>%s</b>\n<small>%s</small>" % (name, summary)821 if self.summary_before_name:
822 contents = "<b>%s</b>\n<small>%s</small>" % (name, summary)
823 else:
824 contents = "<b>%s</b>\n<small>%s</small>" % (summary, name)
820 #TRANSLATORS: the b stands for Bytes825 #TRANSLATORS: the b stands for Bytes
821 size = _("(Size: %s)") % humanize_size(pkg.packageSize)826 size = _("(Size: %s)") % humanize_size(pkg.packageSize)
822 if pkg.installedVersion != None:827 if pkg.installedVersion != None:
823828
=== modified file 'data/update-manager.schemas.in'
--- data/update-manager.schemas.in 2010-03-03 16:12:17 +0000
+++ data/update-manager.schemas.in 2010-06-26 16:22:23 +0000
@@ -96,6 +96,21 @@
96 </locale>96 </locale>
97 </schema>97 </schema>
98 <schema>98 <schema>
99 <key>/schemas/apps/update-manager/summary_before_name</key>
100 <applyto>/apps/update-manager/summary_before_name</applyto>
101 <owner>update-manager</owner>
102 <type>bool</type>
103 <default>True</default>
104
105 <locale name="C">
106 <short>Show package summary before package name in update list</short>
107 <long>
108 If this key is set, the main update list window will
109 show the package summary before the package name.
110 </long>
111 </locale>
112 </schema>
113 <schema>
99 <key>/schemas/apps/update-manager/first_run</key>114 <key>/schemas/apps/update-manager/first_run</key>
100 <applyto>/apps/update-manager/first_run</applyto>115 <applyto>/apps/update-manager/first_run</applyto>
101 <owner>update-manager</owner>116 <owner>update-manager</owner>

Subscribers

People subscribed via source and target branches

to status/vote changes: