Merge lp:~and471/update-manager/fix-bug-386196 into lp:update-manager

Proposed by Andrew
Status: Merged
Merged at revision: 1858
Proposed branch: lp:~and471/update-manager/fix-bug-386196
Merge into: lp:update-manager
Diff against target: 50 lines (+21/-1)
2 files modified
UpdateManager/UpdateManager.py (+6/-1)
data/update-manager.schemas.in (+15/-0)
To merge this branch: bzr merge lp:~and471/update-manager/fix-bug-386196
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+28563@code.launchpad.net

Description of the change

(see commit message and bug report https://bugs.launchpad.net/update-manager/+bug/386196)

To post a comment you must log in.
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This change is in line with the specification I'm working on for how updates should be presented.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/UpdateManager.py'
2--- UpdateManager/UpdateManager.py 2010-06-24 12:43:24 +0000
3+++ UpdateManager/UpdateManager.py 2010-06-26 16:22:23 +0000
4@@ -193,6 +193,8 @@
5 init_proxy(self.gconfclient)
6 # init show version
7 self.show_versions = self.gconfclient.get_bool("/apps/update-manager/show_versions")
8+ # init summary_before_name
9+ self.summary_before_name = self.gconfclient.get_bool("/apps/update-manager/summary_before_name")
10 # keep track when we run (for update-notifier)
11 self.gconfclient.set_int("/apps/update-manager/launch_time", int(time.time()))
12
13@@ -816,7 +818,10 @@
14 if not pkg.is_installed:
15 name += _(" (New install)")
16 summary = xml.sax.saxutils.escape(pkg.summary)
17- contents = "<b>%s</b>\n<small>%s</small>" % (name, summary)
18+ if self.summary_before_name:
19+ contents = "<b>%s</b>\n<small>%s</small>" % (name, summary)
20+ else:
21+ contents = "<b>%s</b>\n<small>%s</small>" % (summary, name)
22 #TRANSLATORS: the b stands for Bytes
23 size = _("(Size: %s)") % humanize_size(pkg.packageSize)
24 if pkg.installedVersion != None:
25
26=== modified file 'data/update-manager.schemas.in'
27--- data/update-manager.schemas.in 2010-03-03 16:12:17 +0000
28+++ data/update-manager.schemas.in 2010-06-26 16:22:23 +0000
29@@ -96,6 +96,21 @@
30 </locale>
31 </schema>
32 <schema>
33+ <key>/schemas/apps/update-manager/summary_before_name</key>
34+ <applyto>/apps/update-manager/summary_before_name</applyto>
35+ <owner>update-manager</owner>
36+ <type>bool</type>
37+ <default>True</default>
38+
39+ <locale name="C">
40+ <short>Show package summary before package name in update list</short>
41+ <long>
42+ If this key is set, the main update list window will
43+ show the package summary before the package name.
44+ </long>
45+ </locale>
46+ </schema>
47+ <schema>
48 <key>/schemas/apps/update-manager/first_run</key>
49 <applyto>/apps/update-manager/first_run</applyto>
50 <owner>update-manager</owner>

Subscribers

People subscribed via source and target branches

to status/vote changes: