Code review comment for lp:~and471/inkscape/ocal-dialog-improvements

Revision history for this message
su_v (suv-lp) wrote :

> Andrew, it would be very disappointing to see all your work lost just because
> you don't have time to investigate more. Would you mind giving write access to
> your branches (OCAL and gallery) to the Inkscape Developers group, so that we
> can work on it?

As mentioned before, I'm not "voting against" the merge - I just want to make sure the issue on OS X is known.

Proposing to merge the ocal branch as is (as long as the two branches haven't diverged too much) and deal with the GIO issues on OS X in trunk (maybe disable the dialog on darwin platforms for the next release if not solved in time).

@ScislaC - would you agree to this?

For the gallery dialog, could the compromise to keep the version with the update button and not rely on monitoring the directory for changes (which failed on OS X, also due to features in GIO apparently not (yet) supported in GTK2 on Mac OS X) be agreed on?
<http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/36401>

« Back to merge proposal