Code review comment for lp:~and471/inkscape/ocal-dialog-improvements

Revision history for this message
su_v (suv-lp) wrote :

> The branch is ready for merging into trunk. Please someone do it quickly!

I repeat my concerns expressed earlier: if doable, please maintain the old dialog in Inkscape's sources for osx users: the new GIO-based dialog fails on OS X and merging the branch as is removes a long-supported feature from that port of Inkscape.

This comment is based on building inkscape from a local branch of 'ocal-dialog-improvements' with up-to-date MacPorts tree required for Inkscape's dependencies, on OS X 10.7.2 Lion (compiler: llvm-gcc-4.2.1):

Chillida:bin su_v$ ./inkscape -V
Inkscape 0.48+devel r10129 (Dec 28 2011)
Chillida:bin su_v$ ./inkscape
Hi!

(inkscape:40831): glibmm-CRITICAL **:
unhandled exception (type Glib::Error) in signal handler:
domain: g-io-error-quark
code : 15
what : Operation not supported

Chillida:bin su_v$ port installed glib2 glibmm gtk2 gtkmm
The following ports are currently installed:
  glib2 @2.30.2_2 (active)
  glibmm @2.28.2_0 (active)
  gtk2 @2.24.8_1+x11 (active)
  gtkmm @2.24.2_0 (active)
Chillida:bin su_v$

« Back to merge proposal