Code review comment for lp:~and471/inkscape/ocal-dialog-improvements

Revision history for this message
Splex (splex) wrote :

Yes, please remove the gnome dependency.

I just tried building inkscape with this diff applied, and get the following errors:

ui/dialog/ocaldialogs.cpp: In member function ‘bool Inkscape::UI::Dialog::OCAL::LoadingBox::_on_expose_event(GdkEventExpose*)’:
ui/dialog/ocaldialogs.cpp:317:49: error: cannot call constructor ‘Glib::ustring::ustring’ directly
ui/dialog/ocaldialogs.cpp:317:49: error: for a function-style cast, remove the redundant ‘::ustring’
ui/dialog/ocaldialogs.cpp: In member function ‘void Inkscape::UI::Dialog::OCAL::LoadingBox::start()’:
ui/dialog/ocaldialogs.cpp:337:47: warning: converting to non-pointer type ‘long int’ from NULL
ui/dialog/ocaldialogs.cpp: In member function ‘bool Inkscape::UI::Dialog::OCAL::BaseBox::_on_expose_event(GdkEventExpose*)’:
ui/dialog/ocaldialogs.cpp:570:49: error: cannot call constructor ‘Glib::ustring::ustring’ directly
ui/dialog/ocaldialogs.cpp:570:49: error: for a function-style cast, remove the redundant ‘::ustring’
make[3]: *** [ui/dialog/ocaldialogs.o] Error 1

« Back to merge proposal