Merge lp:~and471/indicator-network/edit-connection-dialog-prettification into lp:~indicator-applet-developers/indicator-network/indicator-network

Proposed by Andrew
Status: Merged
Merged at revision: 147
Proposed branch: lp:~and471/indicator-network/edit-connection-dialog-prettification
Merge into: lp:~indicator-applet-developers/indicator-network/indicator-network
Diff against target: 447 lines (+57/-169)
1 file modified
src/settings/ui/edit_connection_dialog.ui (+57/-169)
To merge this branch: bzr merge lp:~and471/indicator-network/edit-connection-dialog-prettification
Reviewer Review Type Date Requested Status
Indicator Network Developers Pending
Review via email: mp+50018@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) wrote :

Andy, you are my hero! The dialog looks pretty again :)

We need to look at tab ordering at some point (eg. ipv4 and ipv6 should
be next to each other), but let's worry about that later.

Merged. Thank you.

--
Kalle Valo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/settings/ui/edit_connection_dialog.ui'
--- src/settings/ui/edit_connection_dialog.ui 2011-02-15 11:27:57 +0000
+++ src/settings/ui/edit_connection_dialog.ui 2011-02-16 17:41:49 +0000
@@ -6,7 +6,7 @@
6 <property name="title" translatable="yes">Edit Network</property>6 <property name="title" translatable="yes">Edit Network</property>
7 <property name="window_position">center</property>7 <property name="window_position">center</property>
8 <property name="default_width">440</property>8 <property name="default_width">440</property>
9 <property name="default_height">415</property>9 <property name="default_height">320</property>
10 <child>10 <child>
11 <object class="GtkVBox" id="vbox1">11 <object class="GtkVBox" id="vbox1">
12 <property name="visible">True</property>12 <property name="visible">True</property>
@@ -29,6 +29,7 @@
29 <property name="n_rows">2</property>29 <property name="n_rows">2</property>
30 <property name="n_columns">2</property>30 <property name="n_columns">2</property>
31 <property name="column_spacing">6</property>31 <property name="column_spacing">6</property>
32 <property name="row_spacing">6</property>
32 <child>33 <child>
33 <object class="GtkLabel" id="label4">34 <object class="GtkLabel" id="label4">
34 <property name="visible">True</property>35 <property name="visible">True</property>
@@ -43,10 +44,12 @@
43 <child>44 <child>
44 <object class="GtkLabel" id="label_name">45 <object class="GtkLabel" id="label_name">
45 <property name="visible">True</property>46 <property name="visible">True</property>
47 <property name="xalign">0</property>
46 </object>48 </object>
47 <packing>49 <packing>
48 <property name="left_attach">1</property>50 <property name="left_attach">1</property>
49 <property name="right_attach">2</property>51 <property name="right_attach">2</property>
52 <property name="y_options">GTK_FILL</property>
50 </packing>53 </packing>
51 </child>54 </child>
52 <child>55 <child>
@@ -58,7 +61,6 @@
58 <property name="draw_indicator">True</property>61 <property name="draw_indicator">True</property>
59 </object>62 </object>
60 <packing>63 <packing>
61 <property name="left_attach">1</property>
62 <property name="right_attach">2</property>64 <property name="right_attach">2</property>
63 <property name="top_attach">1</property>65 <property name="top_attach">1</property>
64 <property name="bottom_attach">2</property>66 <property name="bottom_attach">2</property>
@@ -66,9 +68,6 @@
66 <property name="y_options"></property>68 <property name="y_options"></property>
67 </packing>69 </packing>
68 </child>70 </child>
69 <child>
70 <placeholder/>
71 </child>
72 </object>71 </object>
73 </child>72 </child>
74 </object>73 </object>
@@ -92,9 +91,10 @@
92 <child>91 <child>
93 <object class="GtkTable" id="table_wireless">92 <object class="GtkTable" id="table_wireless">
94 <property name="visible">True</property>93 <property name="visible">True</property>
95 <property name="n_rows">8</property>94 <property name="n_rows">3</property>
96 <property name="n_columns">2</property>95 <property name="n_columns">2</property>
97 <property name="column_spacing">6</property>96 <property name="column_spacing">6</property>
97 <property name="row_spacing">6</property>
98 <child>98 <child>
99 <object class="GtkLabel" id="label5">99 <object class="GtkLabel" id="label5">
100 <property name="visible">True</property>100 <property name="visible">True</property>
@@ -109,10 +109,12 @@
109 <child>109 <child>
110 <object class="GtkLabel" id="label_mode">110 <object class="GtkLabel" id="label_mode">
111 <property name="visible">True</property>111 <property name="visible">True</property>
112 <property name="xalign">0</property>
112 </object>113 </object>
113 <packing>114 <packing>
114 <property name="left_attach">1</property>115 <property name="left_attach">1</property>
115 <property name="right_attach">2</property>116 <property name="right_attach">2</property>
117 <property name="y_options">GTK_FILL</property>
116 </packing>118 </packing>
117 </child>119 </child>
118 <child>120 <child>
@@ -144,12 +146,14 @@
144 <child>146 <child>
145 <object class="GtkLabel" id="label_security">147 <object class="GtkLabel" id="label_security">
146 <property name="visible">True</property>148 <property name="visible">True</property>
149 <property name="xalign">0</property>
147 </object>150 </object>
148 <packing>151 <packing>
149 <property name="left_attach">1</property>152 <property name="left_attach">1</property>
150 <property name="right_attach">2</property>153 <property name="right_attach">2</property>
151 <property name="top_attach">1</property>154 <property name="top_attach">1</property>
152 <property name="bottom_attach">2</property>155 <property name="bottom_attach">2</property>
156 <property name="y_options">GTK_FILL</property>
153 </packing>157 </packing>
154 </child>158 </child>
155 <child>159 <child>
@@ -164,38 +168,9 @@
164 <property name="right_attach">2</property>168 <property name="right_attach">2</property>
165 <property name="top_attach">2</property>169 <property name="top_attach">2</property>
166 <property name="bottom_attach">3</property>170 <property name="bottom_attach">3</property>
171 <property name="y_options">GTK_FILL</property>
167 </packing>172 </packing>
168 </child>173 </child>
169 <child>
170 <placeholder/>
171 </child>
172 <child>
173 <placeholder/>
174 </child>
175 <child>
176 <placeholder/>
177 </child>
178 <child>
179 <placeholder/>
180 </child>
181 <child>
182 <placeholder/>
183 </child>
184 <child>
185 <placeholder/>
186 </child>
187 <child>
188 <placeholder/>
189 </child>
190 <child>
191 <placeholder/>
192 </child>
193 <child>
194 <placeholder/>
195 </child>
196 <child>
197 <placeholder/>
198 </child>
199 </object>174 </object>
200 </child>175 </child>
201 </object>176 </object>
@@ -207,7 +182,6 @@
207 <object class="GtkLabel" id="label2">182 <object class="GtkLabel" id="label2">
208 <property name="visible">True</property>183 <property name="visible">True</property>
209 <property name="label" translatable="yes">Wireless</property>184 <property name="label" translatable="yes">Wireless</property>
210 <property name="ellipsize">start</property>
211 </object>185 </object>
212 <packing>186 <packing>
213 <property name="position">1</property>187 <property name="position">1</property>
@@ -222,11 +196,12 @@
222 <property name="left_padding">24</property>196 <property name="left_padding">24</property>
223 <property name="right_padding">12</property>197 <property name="right_padding">12</property>
224 <child>198 <child>
225 <object class="GtkTable" id="table_ipv">199 <object class="GtkTable" id="table_ipv4">
226 <property name="visible">True</property>200 <property name="visible">True</property>
227 <property name="n_rows">8</property>201 <property name="n_rows">4</property>
228 <property name="n_columns">2</property>202 <property name="n_columns">2</property>
229 <property name="column_spacing">6</property>203 <property name="column_spacing">6</property>
204 <property name="row_spacing">6</property>
230 <child>205 <child>
231 <object class="GtkLabel" id="label10">206 <object class="GtkLabel" id="label10">
232 <property name="visible">True</property>207 <property name="visible">True</property>
@@ -288,6 +263,7 @@
288 <property name="right_attach">2</property>263 <property name="right_attach">2</property>
289 <property name="top_attach">1</property>264 <property name="top_attach">1</property>
290 <property name="bottom_attach">2</property>265 <property name="bottom_attach">2</property>
266 <property name="y_options">GTK_FILL</property>
291 </packing>267 </packing>
292 </child>268 </child>
293 <child>269 <child>
@@ -301,6 +277,7 @@
301 <property name="right_attach">2</property>277 <property name="right_attach">2</property>
302 <property name="top_attach">2</property>278 <property name="top_attach">2</property>
303 <property name="bottom_attach">3</property>279 <property name="bottom_attach">3</property>
280 <property name="y_options">GTK_FILL</property>
304 </packing>281 </packing>
305 </child>282 </child>
306 <child>283 <child>
@@ -314,6 +291,7 @@
314 <property name="right_attach">2</property>291 <property name="right_attach">2</property>
315 <property name="top_attach">3</property>292 <property name="top_attach">3</property>
316 <property name="bottom_attach">4</property>293 <property name="bottom_attach">4</property>
294 <property name="y_options">GTK_FILL</property>
317 </packing>295 </packing>
318 </child>296 </child>
319 <child>297 <child>
@@ -323,32 +301,9 @@
323 <packing>301 <packing>
324 <property name="left_attach">1</property>302 <property name="left_attach">1</property>
325 <property name="right_attach">2</property>303 <property name="right_attach">2</property>
304 <property name="y_options">GTK_FILL</property>
326 </packing>305 </packing>
327 </child>306 </child>
328 <child>
329 <placeholder/>
330 </child>
331 <child>
332 <placeholder/>
333 </child>
334 <child>
335 <placeholder/>
336 </child>
337 <child>
338 <placeholder/>
339 </child>
340 <child>
341 <placeholder/>
342 </child>
343 <child>
344 <placeholder/>
345 </child>
346 <child>
347 <placeholder/>
348 </child>
349 <child>
350 <placeholder/>
351 </child>
352 </object>307 </object>
353 </child>308 </child>
354 </object>309 </object>
@@ -376,9 +331,10 @@
376 <child>331 <child>
377 <object class="GtkTable" id="table_dns">332 <object class="GtkTable" id="table_dns">
378 <property name="visible">True</property>333 <property name="visible">True</property>
379 <property name="n_rows">8</property>334 <property name="n_rows">2</property>
380 <property name="n_columns">2</property>335 <property name="n_columns">2</property>
381 <property name="column_spacing">6</property>336 <property name="column_spacing">6</property>
337 <property name="row_spacing">6</property>
382 <child>338 <child>
383 <object class="GtkLabel" id="label6">339 <object class="GtkLabel" id="label6">
384 <property name="visible">True</property>340 <property name="visible">True</property>
@@ -412,10 +368,11 @@
412 <packing>368 <packing>
413 <property name="left_attach">1</property>369 <property name="left_attach">1</property>
414 <property name="right_attach">2</property>370 <property name="right_attach">2</property>
371 <property name="y_options">GTK_FILL</property>
415 </packing>372 </packing>
416 </child>373 </child>
417 <child>374 <child>
418 <object class="GtkEntry" id="entry_domains">375 <object class="GtkEntry" id="entry_domains">
419 <property name="visible">True</property>376 <property name="visible">True</property>
420 <property name="can_focus">True</property>377 <property name="can_focus">True</property>
421 <property name="invisible_char">●</property>378 <property name="invisible_char">●</property>
@@ -425,44 +382,9 @@
425 <property name="right_attach">2</property>382 <property name="right_attach">2</property>
426 <property name="top_attach">1</property>383 <property name="top_attach">1</property>
427 <property name="bottom_attach">2</property>384 <property name="bottom_attach">2</property>
385 <property name="y_options">GTK_FILL</property>
428 </packing>386 </packing>
429 </child>387 </child>
430 <child>
431 <placeholder/>
432 </child>
433 <child>
434 <placeholder/>
435 </child>
436 <child>
437 <placeholder/>
438 </child>
439 <child>
440 <placeholder/>
441 </child>
442 <child>
443 <placeholder/>
444 </child>
445 <child>
446 <placeholder/>
447 </child>
448 <child>
449 <placeholder/>
450 </child>
451 <child>
452 <placeholder/>
453 </child>
454 <child>
455 <placeholder/>
456 </child>
457 <child>
458 <placeholder/>
459 </child>
460 <child>
461 <placeholder/>
462 </child>
463 <child>
464 <placeholder/>
465 </child>
466 </object>388 </object>
467 </child>389 </child>
468 </object>390 </object>
@@ -490,9 +412,10 @@
490 <child>412 <child>
491 <object class="GtkTable" id="table_ipv6">413 <object class="GtkTable" id="table_ipv6">
492 <property name="visible">True</property>414 <property name="visible">True</property>
493 <property name="n_rows">8</property>415 <property name="n_rows">4</property>
494 <property name="n_columns">2</property>416 <property name="n_columns">2</property>
495 <property name="column_spacing">6</property>417 <property name="column_spacing">6</property>
418 <property name="row_spacing">6</property>
496 <child>419 <child>
497 <object class="GtkLabel" id="label11">420 <object class="GtkLabel" id="label11">
498 <property name="visible">True</property>421 <property name="visible">True</property>
@@ -554,6 +477,7 @@
554 <property name="right_attach">2</property>477 <property name="right_attach">2</property>
555 <property name="top_attach">1</property>478 <property name="top_attach">1</property>
556 <property name="bottom_attach">2</property>479 <property name="bottom_attach">2</property>
480 <property name="y_options">GTK_FILL</property>
557 </packing>481 </packing>
558 </child>482 </child>
559 <child>483 <child>
@@ -567,6 +491,7 @@
567 <property name="right_attach">2</property>491 <property name="right_attach">2</property>
568 <property name="top_attach">2</property>492 <property name="top_attach">2</property>
569 <property name="bottom_attach">3</property>493 <property name="bottom_attach">3</property>
494 <property name="y_options">GTK_FILL</property>
570 </packing>495 </packing>
571 </child>496 </child>
572 <child>497 <child>
@@ -580,6 +505,7 @@
580 <property name="right_attach">2</property>505 <property name="right_attach">2</property>
581 <property name="top_attach">3</property>506 <property name="top_attach">3</property>
582 <property name="bottom_attach">4</property>507 <property name="bottom_attach">4</property>
508 <property name="y_options">GTK_FILL</property>
583 </packing>509 </packing>
584 </child>510 </child>
585 <child>511 <child>
@@ -589,32 +515,9 @@
589 <packing>515 <packing>
590 <property name="left_attach">1</property>516 <property name="left_attach">1</property>
591 <property name="right_attach">2</property>517 <property name="right_attach">2</property>
518 <property name="y_options">GTK_FILL</property>
592 </packing>519 </packing>
593 </child>520 </child>
594 <child>
595 <placeholder/>
596 </child>
597 <child>
598 <placeholder/>
599 </child>
600 <child>
601 <placeholder/>
602 </child>
603 <child>
604 <placeholder/>
605 </child>
606 <child>
607 <placeholder/>
608 </child>
609 <child>
610 <placeholder/>
611 </child>
612 <child>
613 <placeholder/>
614 </child>
615 <child>
616 <placeholder/>
617 </child>
618 </object>521 </object>
619 </child>522 </child>
620 </object>523 </object>
@@ -642,9 +545,9 @@
642 <child>545 <child>
643 <object class="GtkTable" id="table_main5">546 <object class="GtkTable" id="table_main5">
644 <property name="visible">True</property>547 <property name="visible">True</property>
645 <property name="n_rows">8</property>
646 <property name="n_columns">2</property>548 <property name="n_columns">2</property>
647 <property name="column_spacing">6</property>549 <property name="column_spacing">6</property>
550 <property name="row_spacing">6</property>
648 <child>551 <child>
649 <object class="GtkLabel" id="label12">552 <object class="GtkLabel" id="label12">
650 <property name="visible">True</property>553 <property name="visible">True</property>
@@ -665,50 +568,9 @@
665 <packing>568 <packing>
666 <property name="left_attach">1</property>569 <property name="left_attach">1</property>
667 <property name="right_attach">2</property>570 <property name="right_attach">2</property>
571 <property name="y_options">GTK_FILL</property>
668 </packing>572 </packing>
669 </child>573 </child>
670 <child>
671 <placeholder/>
672 </child>
673 <child>
674 <placeholder/>
675 </child>
676 <child>
677 <placeholder/>
678 </child>
679 <child>
680 <placeholder/>
681 </child>
682 <child>
683 <placeholder/>
684 </child>
685 <child>
686 <placeholder/>
687 </child>
688 <child>
689 <placeholder/>
690 </child>
691 <child>
692 <placeholder/>
693 </child>
694 <child>
695 <placeholder/>
696 </child>
697 <child>
698 <placeholder/>
699 </child>
700 <child>
701 <placeholder/>
702 </child>
703 <child>
704 <placeholder/>
705 </child>
706 <child>
707 <placeholder/>
708 </child>
709 <child>
710 <placeholder/>
711 </child>
712 </object>574 </object>
713 </child>575 </child>
714 </object>576 </object>
@@ -822,4 +684,30 @@
822 </row>684 </row>
823 </data>685 </data>
824 </object>686 </object>
687 <object class="GtkSizeGroup" id="sizegroup_wireless">
688 <property name="mode">vertical</property>
689 <widgets>
690 <widget name="label_mode"/>
691 <widget name="label_security"/>
692 <widget name="entry_passphrase"/>
693 </widgets>
694 </object>
695 <object class="GtkSizeGroup" id="sizegroup_ipv4">
696 <property name="mode">vertical</property>
697 <widgets>
698 <widget name="entry_ipv4_address"/>
699 <widget name="entry_ipv4_netmask"/>
700 <widget name="entry_ipv4_gateway"/>
701 <widget name="combobox_ipv4_method"/>
702 </widgets>
703 </object>
704 <object class="GtkSizeGroup" id="sizegroup_ipv6">
705 <property name="mode">vertical</property>
706 <widgets>
707 <widget name="entry_ipv6_address"/>
708 <widget name="entry_ipv6_prefix_length"/>
709 <widget name="entry_ipv6_gateway"/>
710 <widget name="combobox_ipv6_method"/>
711 </widgets>
712 </object>
825</interface>713</interface>

Subscribers

People subscribed via source and target branches