Code review comment for lp:~amujumdar/bzr-xmloutput/emit_authors

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi, the change looks good, just 2 notes:

1) please leave 1 empty line between methods
2) the test doesn't work, it's just a typo.

======================================================================
ERROR: bzrlib.plugins.xmloutput.tests.test_log_xml.TestLog.test_log_author
----------------------------------------------------------------------
_StringException: Empty attachments:
  log

Traceback (most recent call last):
  File "/home/guillermo/.bazaar/plugins/xmloutput/tests/test_log_xml.py", line 211, in test_log_author
    self_prepare()
NameError: global name 'self_prepare' is not defined

----------------------------------------------------------------------
Ran 96 tests in 6.139s

FAILED (errors=1)
1 test skipped

review: Needs Fixing

« Back to merge proposal