Code review comment for lp:~ams-codesourcery/gcc-linaro/merge-from-fsf-trunk-20120214

cbuild successfully built this on i686-natty-cbuild245-oort2-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114966~ams-codesourcery~merge-from-fsf-trunk-20120214/logs/i686-natty-cbuild245-oort2-i686r1

-PASS: c-c++-common/cxxbitfields-3.c scan-assembler movl.*, var
-PASS: c-c++-common/cxxbitfields-3.c scan-assembler movl.*, var
+PASS: c-c++-common/cxxbitfields-3.c scan-assembler movl.*, _?var
+PASS: c-c++-common/cxxbitfields-3.c scan-assembler movl.*, _?var
+PASS: c-c++-common/pr52177.c -std=gnu++11 (test for excess errors)
+PASS: c-c++-common/pr52177.c -std=gnu++98 (test for excess errors)
+PASS: c-c++-common/pr52181.c -std=c++11 (test for bogus messages, line 11)
+PASS: c-c++-common/pr52181.c -std=c++11 (test for excess errors)
+PASS: c-c++-common/pr52181.c -std=c++98 (test for bogus messages, line 11)
+PASS: c-c++-common/pr52181.c -std=c++98 (test for excess errors)
+PASS: g++.dg/cpp0x/constexpr-union3.C (test for excess errors)
+PASS: g++.dg/ext/atomic-1.C -std=c++11 (test for excess errors)
+PASS: g++.dg/ext/atomic-1.C -std=c++98 (test for excess errors)
+PASS: g++.dg/lto/pr52035 cp_lto_pr52035_0.o assemble, -O0 -flto -flto-partition=1to1 -fno-use-linker-plugin
+PASS: g++.dg/lto/pr52035 cp_lto_pr52035_0.o assemble, -O0 -flto -flto-partition=none -fuse-linker-plugin
+PASS: g++.dg/lto/pr52035 cp_lto_pr52035_0.o assemble, -O0 -flto -fuse-linker-plugin -fno-fat-lto-objects
+PASS: g++.dg/lto/pr52035 cp_lto_pr52035_0.o assemble, -O2 -flto -flto-partition=1to1 -fno-use-linker-plugin
+PASS: g++.dg/lto/pr52035 cp_lto_pr52035_0.o assemble, -O2 -flto -flto-partition=none -fuse-linker-plugin -fno-fat-lto-objects
+PASS: g++.dg/lto/pr52035 cp_lto_pr52035_0.o assemble, -O2 -flto -fuse-linker-plugin
+PASS: g++.dg/overload/defarg5.C -std=c++11 (test for errors, line 6)
+PASS: g++.dg/overload/defarg5.C -std=c++11 (test for excess errors)
+PASS: g++.dg/overload/defarg5.C -std=c++98 (test for errors, line 6)
+PASS: g++.dg/overload/defarg5.C -std=c++98 (test for excess errors)
+PASS: g++.dg/template/conv13.C -std=c++11 (test for errors, line 12)
+PASS: g++.dg/template/conv13.C -std=c++11 (test for excess errors)
+PASS: g++.dg/template/conv13.C -std=c++98 (test for errors, line 12)
+PASS: g++.dg/template/conv13.C -std=c++98 (test for excess errors)
+PASS: g++.dg/template/repo10.C -std=gnu++11 (test for excess errors)
+PASS: g++.dg/template/repo10.C -std=gnu++98 (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O0 (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O1 (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O2 (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O2 -flto -fno-use-linker-plugin -flto-partition=none (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O3 -fomit-frame-pointer (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O3 -fomit-frame-pointer -funroll-loops (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -O3 -g (test for excess errors)
+PASS: g++.dg/torture/pr48600.C -Os (test for excess errors)
-PASS: c-c++-common/cxxbitfields-3.c scan-assembler movl.*, var
+PASS: c-c++-common/cxxbitfields-3.c scan-assembler movl.*, _?var
+PASS: c-c++-common/pr52177.c -Wc++-compat (test for excess errors)
+PASS: c-c++-common/pr52181.c -Wc++-compat (test for bogus messages, line 11)
+PASS: c-c++-common/pr52181.c -Wc++-compat (test for excess errors)
-PASS: c-c++-common/simulate-thread/bitfields-1.c -O1 -g (test for excess errors)
-PASS: c-c++-common/simulate-thread/bitfields-1.c -O1 -g thread simulation test
-PASS: c-c++-common/simulate-thread/bitfields-1.c -Os -g (test for excess errors)
-PASS: c-c++-common/simulate-thread/bitfields-1.c -Os -g thread simulation test
-PASS: c-c++-common/simulate-thread/bitfields-2.c -O1 -g (test for excess errors)
-PASS: c-c++-common/simulate-thread/bitfields-2.c -O1 -g thread simulation test
...and 296 more

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114966~ams-codesourcery~merge-from-fsf-trunk-20120214/logs/i686-natty-cbuild245-oort2-i686r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114966~ams-codesourcery~merge-from-fsf-trunk-20120214/logs/i686-natty-cbuild245-oort2-i686r1/gcc-testsuite.txt

cbuild-checked: i686-natty-cbuild245-oort2-i686r1