Code review comment for lp:~amir-mohammadkhani/kicad/ash

On 09/29/2010 09:24 AM, Amir Mohammadkhani-Aminabadi wrote:
> Review: Approve
> So far we have 1 vote for and 1 against.
>
>
> Dick: In your first reply it seems you did not even read past "Changes for VC" since you wanted to trash the whole patch without even going into detail about >real non VC issues< that needed to be fixed.
>

My last reply is more important.

I committed the pieces of your patch that I thought appropriate in
testing revision 2509. Your edits to basicframe.cpp would not compile
with g++ so I rewrote all that code.

Read my last reply and HAND EDIT your project file as an experimental
aid in determining what CMake needs to generate in order to create an
acceptable project file contain the 3 lines of comments.

CMake folks can take a patch and build a windows nightly download for you.

Your hard drive does not have to get filled up with CMake source files
if you do not want.

This will tells us if the bug is in CMake or in Visual C++.

It is not in CMakeLists.txt

Dick