Code review comment for lp:~amanica/bzr/log_returns_too_much

Revision history for this message
Marius Kruger (amanica) wrote :

2009/7/9 John A Meinel <email address hidden>
>
> So here are my thoughts...
thanks

> If we are going to do this then:
>
> 1) "bzr log -r 10" should show just the revision 10

that is what this patch does

> 2) "bzr log -c 10" should show all the changes that were merged into 10

sounds like a must have feature otherwise its really difficult to
figure out what happened
(I resorted to bzr explorer & qlog to be able to successfully navigate this)
bzr diff seems to work that way too.

> 3) "bzr log -r 9..11" should *not* show the revision for 9, but show
> everything that was merged into 10 and 11.
>
> Basically, we would unify it with similar commands (like diff) which for
> "-r X..Y" mean "show what is in Y that is not in X".

That is https://bugs.launchpad.net/bzr/+bug/320119
which was more or less my next step.

I like your suggestions, it would make log&diff more consistent.
I'm keen to implement them as soon as time permits.

« Back to merge proposal