Merge lp:~allison/ubuntu/raring/gpsdrive/merge-debian-patches2 into lp:ubuntu/raring/gpsdrive

Proposed by Allison Randal
Status: Merged
Merge reported by: Iain Lane
Merged at revision: not available
Proposed branch: lp:~allison/ubuntu/raring/gpsdrive/merge-debian-patches2
Merge into: lp:ubuntu/raring/gpsdrive
Diff against target: 184 lines (+80/-49)
7 files modified
debian/changelog (+38/-1)
debian/patches/00list (+3/-3)
debian/patches/104-fix-xcursor-check.dpatch (+19/-0)
debian/patches/105-add-boost-links.dpatch (+19/-0)
debian/patches/105-fix-xcursor-check.dpatch (+0/-22)
debian/patches/106-add-boost-links.dpatch (+0/-22)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~allison/ubuntu/raring/gpsdrive/merge-debian-patches2
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Ubuntu branches Pending
Review via email: mp+143996@code.launchpad.net

Description of the change

Added comment to debian/changelog about preserved Ubuntu changes to config.guess and config.sub.

See earlier conversation on this merge at:

https://code.launchpad.net/~allison/ubuntu/raring/gpsdrive/merge-debian-patches/+merge/143035

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks. Uploaded.

review: Approve
Revision history for this message
Micah Gersten (micahg) wrote :

I think this is still wrong, but I see it was uploaded. I don't believe the config.* diff necessary to build the package as we're running autoconf during the build. I see the Debian package builds fine on Ubuntu without the changes

Revision history for this message
Allison Randal (allison) wrote :

I kept it because of the architecture-specific hints it provides. These weren't random changes, I carefully checked the old Debian versions of the package to make sure the diffs didn't creep in from an improperly made merge.

But, my plan next month is to update the Debian packages to 2.11. (See LP #819145.) After that, we should be able to drop all Ubuntu changes and simply sync the updated package.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-12-02 09:52:13 +0000
+++ debian/changelog 2013-01-19 19:25:22 +0000
@@ -1,3 +1,41 @@
1gpsdrive (2.10~pre4-6.dfsg-5.2ubuntu1) raring; urgency=low
2
3 * Merge from Debian unstable, remaining changes:
4 - scripts/geo-code: Changed executing environment from /bin/sh
5 to /bin/bash. Resequenced as debian/patches/106-lp-325288.dpatch
6 - Preserved config.{guess,sub} override.
7 * Dropped changes:
8 - debian/patches/107-fix-disable-mapnik.dpatch: now upstream in Debian.
9 - debian/patches/105-fix-xcursor-check.dpatch removed,
10 in Debian as 104-fix-xcursor-check.dpatch.
11 - debian/patches/106-add-boost-links.dpatch removed,
12 in Debian as 105-add-boost-links.dpatch.
13
14 -- Allison Randal <allison@ubuntu.com> Sat, 19 Jan 2013 10:42:27 -0800
15
16gpsdrive (2.10~pre4-6.dfsg-5.2) unstable; urgency=low
17
18 * Non-maintainer upload
19
20 [ Allison Randal ]
21 * Disable optional mapnik libraries, gpsdrive is incompatible with
22 APIs of mapnik version 2.0.0.
23 * debian/patches/107-fix-disable-mapnik.dpatch:
24 Fix known bug with gpsdrive-2.10pre4 when disabling Mapnik library.
25
26 -- Christian Perrier <bubulle@debian.org> Sun, 07 Oct 2012 14:27:36 +0200
27
28gpsdrive (2.10~pre4-6.dfsg-5.1) unstable; urgency=medium
29
30 * Non-maintainer upload.
31 * debian/patches/104-fix-xcursor-check.dpatch:
32 - Define Xcursor within AC_CHECK_LIB, fix FTBFS.
33 (Closes: #615653, 628310)
34 * debian/patches/105-add-boost-links.dpatch:
35 - Link against boost-filesystem and boost-system.
36
37 -- Luca Falavigna <dktrkranz@debian.org> Thu, 01 Sep 2011 22:44:02 +0200
38
1gpsdrive (2.10~pre4-6.dfsg-5ubuntu4) precise; urgency=low39gpsdrive (2.10~pre4-6.dfsg-5ubuntu4) precise; urgency=low
240
3 * Disable optional mapnik libraries, gpsdrive is incompatible with41 * Disable optional mapnik libraries, gpsdrive is incompatible with
@@ -169,7 +207,6 @@
169207
170 -- Andreas Putzo <andreas@putzo.net> Sat, 19 Jul 2008 20:01:39 +0000208 -- Andreas Putzo <andreas@putzo.net> Sat, 19 Jul 2008 20:01:39 +0000
171209
172>>>>>>> .r2096
173gpsdrive (2.10~pre4-3) unstable; urgency=low210gpsdrive (2.10~pre4-3) unstable; urgency=low
174211
175 * Fix regression of last upload in the mapnik handling.212 * Fix regression of last upload in the mapnik handling.
176213
=== modified file 'debian/patches/00list'
--- debian/patches/00list 2011-12-01 22:58:43 +0000
+++ debian/patches/00list 2013-01-19 19:25:22 +0000
@@ -19,7 +19,7 @@
19101-signalposreq19101-signalposreq
20102-unittest20102-unittest
21103-no-textquery21103-no-textquery
22104-lp-32528822104-fix-xcursor-check
23105-fix-xcursor-check.dpatch23105-add-boost-links
24106-add-boost-links.dpatch24106-lp-325288
25107-fix-disable-mapnik.dpatch25107-fix-disable-mapnik.dpatch
2626
=== added file 'debian/patches/104-fix-xcursor-check.dpatch'
--- debian/patches/104-fix-xcursor-check.dpatch 1970-01-01 00:00:00 +0000
+++ debian/patches/104-fix-xcursor-check.dpatch 2013-01-19 19:25:22 +0000
@@ -0,0 +1,19 @@
1#! /bin/sh /usr/share/dpatch/dpatch-run
2## Description: XcursorImageCreate is defined in Xcursor
3## Origin/Author: Julian Taylor <jtaylor.debian@googlemail.com>
4## Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=615653
5## fix-xcursor-check.dpatch by Julian Taylor <jtaylor.debian@googlemail.com>
6
7@DPATCH@
8diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' gpsdrive~/configure.ac gpsdrive/configure.ac
9--- gpsdrive~/configure.ac 2011-07-05 13:43:55.000000000 +0200
10+++ gpsdrive/configure.ac 2011-07-05 13:51:30.531707412 +0200
11@@ -471,7 +471,7 @@
12 if $PKG_CONFIG xcursor --atleast-version=1.1.2
13 then
14 AC_MSG_RESULT([yes])
15- AC_CHECK_LIB(fontconfig, XcursorImageCreate, [], [
16+ AC_CHECK_LIB(Xcursor, XcursorImageCreate, [], [
17 echo "Error with test of xcursor library not found"
18 exit -1
19 ])
020
=== added file 'debian/patches/105-add-boost-links.dpatch'
--- debian/patches/105-add-boost-links.dpatch 1970-01-01 00:00:00 +0000
+++ debian/patches/105-add-boost-links.dpatch 2013-01-19 19:25:22 +0000
@@ -0,0 +1,19 @@
1#! /bin/sh /usr/share/dpatch/dpatch-run
2## Description: requires direct link against boost {file,}system
3## Origin/Author: Julian Taylor <jtaylor.debian@googlemail.com>
4## Bug: https://bugs.launchpad.net/ubuntu/+source/gpsdrive/+bug/749273
5## 105-add-boost-links.dpatch by Julian Taylor <jtaylor.debian@googlemail.com>
6
7@DPATCH@
8diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' gpsdrive~/src/Makefile.am gpsdrive/src/Makefile.am
9--- gpsdrive~/src/Makefile.am 2011-07-05 13:59:11.000000000 +0200
10+++ gpsdrive/src/Makefile.am 2011-07-05 14:02:23.341707820 +0200
11@@ -42,7 +42,7 @@
12 INCLUDES = $(DBUS_CFLAGS) -DDBUS_API_SUBJECT_TO_CHANGE=1
13 endif
14
15-gpsdrive_LDADD=@LIBS@ $(LIBADD_DL)
16+gpsdrive_LDADD=@LIBS@ $(LIBADD_DL) -lboost_filesystem -lboost_system
17
18 PRGS = gpsdrive.c splash.c splash.h gpsdrive_config.c gpsdrive_config.h \
19 navigation.c \
020
=== removed file 'debian/patches/105-fix-xcursor-check.dpatch'
--- debian/patches/105-fix-xcursor-check.dpatch 2011-11-23 23:34:54 +0000
+++ debian/patches/105-fix-xcursor-check.dpatch 1970-01-01 00:00:00 +0000
@@ -1,22 +0,0 @@
1#! /bin/sh /usr/share/dpatch/dpatch-run
2## Description: XcursorImageCreate is defined in Xcursor
3## Origin/Author: Julian Taylor <jtaylor.debian@googlemail.com>
4## Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=615653
5## fix-xcursor-check.dpatch by Julian Taylor <jtaylor.debian@googlemail.com>
6##
7## All lines beginning with `## DP:' are a description of the patch.
8## DP: No description.
9
10@DPATCH@
11diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' gpsdrive~/configure.ac gpsdrive/configure.ac
12--- gpsdrive~/configure.ac 2011-07-05 13:43:55.000000000 +0200
13+++ gpsdrive/configure.ac 2011-07-05 13:51:30.531707412 +0200
14@@ -471,7 +471,7 @@
15 if $PKG_CONFIG xcursor --atleast-version=1.1.2
16 then
17 AC_MSG_RESULT([yes])
18- AC_CHECK_LIB(fontconfig, XcursorImageCreate, [], [
19+ AC_CHECK_LIB(Xcursor, XcursorImageCreate, [], [
20 echo "Error with test of xcursor library not found"
21 exit -1
22 ])
230
=== removed file 'debian/patches/106-add-boost-links.dpatch'
--- debian/patches/106-add-boost-links.dpatch 2011-07-05 12:30:16 +0000
+++ debian/patches/106-add-boost-links.dpatch 1970-01-01 00:00:00 +0000
@@ -1,22 +0,0 @@
1#! /bin/sh /usr/share/dpatch/dpatch-run
2## Description: requires direct link against boost {file,}system
3## Origin/Author: Julian Taylor <jtaylor.debian@googlemail.com>
4## Bug: https://bugs.launchpad.net/ubuntu/+source/gpsdrive/+bug/749273
5## 105-add-boost-links.dpatch by Julian Taylor <jtaylor.debian@googlemail.com>
6##
7## All lines beginning with `## DP:' are a description of the patch.
8## DP: No description.
9
10@DPATCH@
11diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' gpsdrive~/src/Makefile.am gpsdrive/src/Makefile.am
12--- gpsdrive~/src/Makefile.am 2011-07-05 13:59:11.000000000 +0200
13+++ gpsdrive/src/Makefile.am 2011-07-05 14:02:23.341707820 +0200
14@@ -42,7 +42,7 @@
15 INCLUDES = $(DBUS_CFLAGS) -DDBUS_API_SUBJECT_TO_CHANGE=1
16 endif
17
18-gpsdrive_LDADD=@LIBS@ $(LIBADD_DL)
19+gpsdrive_LDADD=@LIBS@ $(LIBADD_DL) -lboost_filesystem -lboost_system
20
21 PRGS = gpsdrive.c splash.c splash.h gpsdrive_config.c gpsdrive_config.h \
22 navigation.c \
230
=== renamed file 'debian/patches/104-lp-325288.dpatch' => 'debian/patches/106-lp-325288.dpatch'
=== modified file 'debian/rules'
--- debian/rules 2011-12-01 22:58:43 +0000
+++ debian/rules 2013-01-19 19:25:22 +0000
@@ -58,7 +58,7 @@
58build: build-arch build-indep58build: build-arch build-indep
5959
60build-arch: config.status build-arch-stamp60build-arch: config.status build-arch-stamp
61build-arch-stamp:61build-arch-stamp: config.status
62 dh_testdir62 dh_testdir
63 $(MAKE)63 $(MAKE)
64 touch $@64 touch $@

Subscribers

People subscribed via source and target branches