Merge ~allenpthuang/ubuntu-security-tools:umt-check-latest-versions into ubuntu-security-tools:master

[Allen Huang]

This change makes `umt check` show more accurate results in the section of "Upgradeable version" of its report.

The result in the Upgradeable version section is generated by `package-tools/check-source-package`. It did not always compare against the most updated versions from `-updates` and `-security`.
In this change, a helper function `pick_latest_version_helper()` is added to pick the latest version for comparisons in `check_version()`. The function keeps the newest version it has seen in pockets of every release (e.g. `jammy`, `jammy-security` and `jammy-updates`) and passes it to `compare_version()`. It keeps all versions from every pocket of a release if the versions are equally new.

[David Fernandez Gonzalez (litios)]

LGTM! Working as expected, thanks for doing this.

review: Approve

diff --git a/package-tools/check-source-package b/package-tools/check-source-package
index 18fe688..a420b19 100755
--- a/package-tools/check-source-package
+++ b/package-tools/check-source-package
@@ -655,6 +655,31 @@ check_origtargz() {
     fi
 }
 
+pick_latest_version_helper() {
+    declare -A results
+    # read versions and releases from the original $rmadout
+    while read -r incoming_ver release; do
+        # reduce to base release names (e.g. lunar-security/universe to lunar)
+        local base_rel=${release%%[-/]*}
+        # if the base_rel is never seen before, add it to the array
+        if [ -z "${results[$base_rel]}" ]; then
+            results["$base_rel"]="$incoming_ver $release"
+        else # if seen before, compare the versions
+            local cur_ver=$(echo "${results[$base_rel]}" | awk '{print $1}')
+            # if the versions are the same, append it to the output line
+            # if the incoming version is greater, replace the output line
+            if dpkg --compare-versions "$cur_ver" eq "$incoming_ver"; then
+                results["$base_rel"]="$incoming_ver $release"";""${results[$base_rel]}"
+            elif dpkg --compare-versions "$cur_ver" lt "$incoming_ver"; then
+                results["$base_rel"]="$incoming_ver $release"
+            fi
+        fi
+    done < <(echo "$1" | awk '{print $3 " " $5}')
+
+    # print to stdout and expand the line with multiple entries
+    printf "%s\n" "${results[@]}" | tr ';' '\n'
+}
+
 check_version() {
     format_test_name "Version"
     dist=$(awk '/^Distribution: / {print $2}' "$schanges")
@@ -748,7 +773,7 @@ check_version() {
         else
           echo "SKIP: Unable to get date_created for old release $olddist"
         fi
-      done < <(echo "$rmadout" | awk '{print $3 " " $5}')
+      done < <(pick_latest_version_helper "$rmadout")
       if [ -n "$superceded" ]; then
         failed "FAIL"
         echo " Current: $version in $dist"