Merge lp:~allenap/txlongpollfixture/bits-n-bobs into lp:txlongpollfixture

Proposed by Gavin Panella
Status: Merged
Approved by: Julian Edwards
Approved revision: 27
Merged at revision: 27
Proposed branch: lp:~allenap/txlongpollfixture/bits-n-bobs
Merge into: lp:txlongpollfixture
Diff against target: 96 lines (+28/-10)
4 files modified
.bzrignore (+8/-0)
Makefile (+8/-2)
README (+11/-7)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~allenap/txlongpollfixture/bits-n-bobs
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Raphaël Badin (community) code* Approve
Review via email: mp+77182@code.launchpad.net

Description of the change

Variety of fixes, including a version bump.

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

Thanks for the cleanup & fixes.

43 - $(RM) -r .installed.cfg
44 + $(RM) .installed.cfg

Whaouh, that's laser-sharp cleanup ;).

review: Approve (code*)
Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file '.bzrignore'
--- .bzrignore 1970-01-01 00:00:00 +0000
+++ .bzrignore 2011-09-27 15:13:36 +0000
@@ -0,0 +1,8 @@
1*.egg-info
2./.installed.cfg
3./bin
4./develop-eggs
5./dist
6./download-cache
7./eggs
8./parts
09
=== modified file 'Makefile'
--- Makefile 2011-09-26 09:35:28 +0000
+++ Makefile 2011-09-27 15:13:36 +0000
@@ -37,24 +37,30 @@
37build: $(BUILDOUT_BIN)37build: $(BUILDOUT_BIN)
3838
3939
40dist: setup.py40dist: $(PY)
41 $(PY) setup.py egg_info -r sdist41 $(PY) setup.py egg_info -r sdist
4242
4343
44check: bin/test44check: bin/test
45 ./bin/test -vv45 ./bin/test -vv
4646
47
47clean: clean_buildout clean_eggs48clean: clean_buildout clean_eggs
4849
50
49clean_eggs:51clean_eggs:
52 $(RM) -r download-cache
53 $(RM) -r *.egg-info
50 $(RM) -r eggs54 $(RM) -r eggs
5155
56
52clean_buildout:57clean_buildout:
53 $(RM) -r bin58 $(RM) -r bin
54 $(RM) -r parts59 $(RM) -r parts
55 $(RM) -r develop-eggs60 $(RM) -r develop-eggs
56 $(RM) -r .installed.cfg61 $(RM) .installed.cfg
57 $(RM) -r build62 $(RM) -r build
63 $(RM) -r dist
5864
5965
60.PHONY: build check default dist clean clean_buildout clean_eggs66.PHONY: build check default dist clean clean_buildout clean_eggs
6167
=== modified file 'README'
--- README 2011-09-27 09:48:55 +0000
+++ README 2011-09-27 15:13:36 +0000
@@ -13,17 +13,21 @@
1313
14 $ make check14 $ make check
1515
16
16Running17Running
17-------18-------
1819
19Make sure that the buildout-generated bin/ directory containing the txlongpoll20Make sure that the buildout-generated bin/ directory containing the
20executable is in the PATH or the fixture won't find it.21txlongpoll executable is in the PATH, or specify an absolute path
22with txlongpoll_bin, otherwise the fixture won't find it.
2123
22Example usage:24Example usage:
2325
24 >>> class MyTest(testtools.TestCase):26 >>> class MyTest(testtools.TestCase):
25 ... fixture = TxLongPollFixture(27 ... def test_thingy(self):
26 ... broker_user="guest", broker_password="guest", frontend_port=9999,28 ... fixture = TxLongPollFixture(
27 ... broker_vhost="/", broker_host="localhost", broker_port=5672,29 ... frontend_port=9999, broker_user="guest",
28 ... txlongpoll_bin="txlongpoll")30 ... broker_password="guest", broker_vhost="/",
29 ... self.useFixture()31 ... broker_host="localhost", broker_port=5672,
32 ... txlongpoll_bin="txlongpoll")
33 ... self.useFixture(fixture)
3034
=== removed directory 'download-cache'
=== modified file 'setup.py'
--- setup.py 2011-09-23 15:09:06 +0000
+++ setup.py 2011-09-27 15:13:36 +0000
@@ -6,7 +6,7 @@
66
7setup(7setup(
8 name='txlongpollfixture',8 name='txlongpollfixture',
9 version="0.1",9 version="0.1.1",
10 packages=find_packages('.'),10 packages=find_packages('.'),
11 package_dir={'': '.'},11 package_dir={'': '.'},
12 include_package_data=True,12 include_package_data=True,

Subscribers

People subscribed via source and target branches

to all changes: