Code review comment for lp:~allenap/storm/value-columns-by-name

Revision history for this message
James Henstridge (jamesh) wrote :

If we want to support this feature, it should probably exclude all tuple finds. For example:

  result = store.find((Company, Employee), Company.id == Employee.company_id)
  ids = result.values('id')

Assuming both tables have an 'id' column, which one am I referring to? It seems better to limit the feature to the simple situations where we can handle it unambiguously.

review: Needs Fixing

« Back to merge proposal