Code review comment for lp:~allenap/storm/oneiric-admin-shutdown-bug-871596

I'm getting weird Segmentation fault errors when running the test suite but I know this is not unheard of when dealing with storm :/.

    test_terminated_backend (tests.databases.postgres.PostgresDisconnectionTestWithoutProxyUnixSockets) ... Segmentation fault

I suppose you have all the tests passing so it must be something with my setup.

Apart from that, this looks good. (I confess I'd like to know more about pgbouncer but right now http://pgfoundry.org/projects/pgbouncer says "PgFoundry Could Not Connect to Database:").

[0]

8 -include MANIFEST.in LICENSE README TODO NEWS Makefile setup.cfg test
9 +include MANIFEST.in LICENSE README TODO NEWS Makefile setup.cfg test ez_setup.py

This should probably go in the prereq branch but since you're going to land them together I guess that's ok ;)

[1]

317 +if has_fixtures:
318 + # Upgrade to full test case class with fixtures.
319 + from fixtures import TestWithFixtures
320 + class PostgresDisconnectionTestWithPGBouncer(
321 + PostgresDisconnectionTestWithPGBouncerBase,
322 + TestWithFixtures, TestHelper): pass

I don't think that's very readable but I have no better idea atm…