Code review comment for lp:~allenap/rabbitfixture/rabbitmq-3.3-and-later

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for solving this mystery! Impressive diagnostic work. EnvironmentVariableFixture is starting to look a bit tedious — if only it'd take a dict, or **kwargs...

One suggestion for the branch: if the test verified that the port numbers were in range, might that not have revealed this problem earlier on?

review: Approve

« Back to merge proposal