Code review comment for lp:~allenap/python-pgbouncer/reliable-shutdown
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
I'm not done reviewing this yet, but a few questions first:
* I guess if the test dies, pgbouncer will now die as well so you don't need a pidfile to set things right during a later run?
* Why treat the files you open as binary? Take a pidfile, for instance. I don't suppose it'll ever matter, but isn't that a text file? Adding the "b" to the open modes seems to confuse more than help.